Skip to content

add epsilon term to npv activity coefficients #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add epsilon term to npv activity coefficients #994

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7894e22
add temporary npv enabled model for testing
Aurashk Nov 7, 2025
c4c1f5b
remove tmp file
Aurashk Nov 10, 2025
a893229
use const and clearer comment for ac epsilon
Aurashk Nov 11, 2025
c6b6b90
use f64::EPSILON
Aurashk Nov 11, 2025
26d18c2
Update src/simulation/investment/appraisal/coefficients.rs
Aurashk Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/simulation/investment/appraisal/coefficients.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,14 @@ pub fn calculate_coefficients_for_npv(
// Capacity coefficient
let capacity_coefficient = -annual_fixed_cost(asset);

// Small epsilon to ensure break-even assets are dispatched
let epsilon = MoneyPerActivity(1e-14);
Copy link
Collaborator

@tsmbland tsmbland Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would define this as a const at the top of the function. E.g. see

MUSE2/src/input.rs

Line 182 in 29a9a30

const MAX_DISPLAY: usize = 10;

Copy link
Collaborator

@dalonsoa dalonsoa Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also use f64::EPSILON, so it is not an arbitrary small number. See https://doc.rust-lang.org/std/f64/constant.EPSILON.html

Copy link
Collaborator Author

@Aurashk Aurashk Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's interesting didn't know about that. I changed it to f64::EPSILON * 100.0 because we need it to big enough to force out precision errors. Multiplying by 100.0 is still a bit arbitrary but seems more elegant this way


// Activity coefficients
let mut activity_coefficients = IndexMap::new();
for time_slice in time_slice_info.iter_ids() {
let coefficient = calculate_activity_coefficient_for_npv(asset, time_slice, prices, year);
activity_coefficients.insert(time_slice.clone(), coefficient);
activity_coefficients.insert(time_slice.clone(), coefficient + epsilon);
}

// Unmet demand coefficient (we don't apply a cost to unmet demand, so we set this to zero)
Expand Down