-
Notifications
You must be signed in to change notification settings - Fork 57
feature(wallet, links, tx, yoroi-lib, etc.): Mobile experimental #4347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
aca7811
06cc8e1
74352c1
48623c7
120e83e
bbdfb84
fd90c59
6ef5f12
ea05efe
3cd7751
b8b925d
c8c07d5
0582cba
bef0f7b
87b019c
81f2756
0de18f2
42691a8
5ed9250
8b7eaeb
a8cb058
681f0ec
543cde3
fa5338a
8c23ac9
a642a7e
457f473
f0ca420
851a915
302d9fb
2ec3187
9b68cb9
31e2de9
97c1a37
3ef464f
1f9939b
5298500
0629460
7913d72
826c85d
5a07ba8
b1ffca4
3d81676
3c5e992
5b0a899
c77773c
fe09cb8
9bc7643
8160682
6f9692a
a1ab740
4805fe5
48eac49
6fa4a0e
9d287b8
4c32efb
38d1092
d66648f
116d44d
63866c1
3d053e9
02eeef4
ebcadf7
347a6cb
5ffaaa2
c539fe0
ef0b3a7
7cc4026
c61df6b
f9c22e5
b9066b2
f31df62
e79dcb2
bfd7a2c
3b79727
3464a49
884f9c0
386daba
765a1ef
562d00a
f26ce28
92a74f8
a4fe159
f5193fb
f9826ae
8a022ad
7f68cc7
aeca938
fa21467
a6e8e94
c79c206
1ef7201
de3da93
999bf3b
dba0177
5e900a5
0771ec0
9ba07df
87e05e0
be799bb
d77e63b
f736e6b
3366bd4
9a4e4ca
c30fe98
a81ef6c
51c79d6
5415c38
f4746b5
62a75ce
11c225e
bdd7310
6113d57
30cbb5e
90739b9
cf9274e
3915956
6d10b28
b56788f
d0fe73a
990517a
ea6b6d7
09d5463
c1e8f9f
5eb9852
7fc9393
4571a71
ef5e89c
f5a1706
c1e6d1d
afd58e8
6d51bdd
e6bfd39
f59d33e
ffc6081
886e102
52c91fe
fcc7296
aeabef1
285acb1
0d91ede
2853038
323bcf8
65816cd
5aa55fd
e50430e
20544a4
56e7e38
8bcb2ee
b3a5c0c
676bcc2
dfc9e9e
4b7452d
2a26911
ee7e7ad
de5dda4
b111b45
576d9eb
bcac619
b861ed5
ffb734e
5cb1611
85ee087
6a4062a
8091f3f
3f15ba2
60884d0
0406b68
c94080d
8152614
ac2ba62
30f220e
f3d0b12
e8ead0b
c9998b9
d9b74f7
823c153
eacda7c
c9032c1
1dffa29
5f928cb
ea7221c
a8d4579
cf2ea5d
87cc883
83df7a2
030e26f
a0a7a15
09ec0c1
de09832
8dbde3b
ab9ca9b
8f7629b
9727585
604a31b
09ab13e
d2ce485
71bf8b2
4e945c1
b31a771
2f85c3e
a11b9d4
25f57db
25229f5
2411acf
359f89b
ebc8221
46089fd
8f3e993
5320769
6d9cc99
aef8242
7512a3d
692cc5b
7e1feba
1f28b2b
4855b09
e9d7a9d
8b1ad9e
d524dce
38477e7
ea2cde4
7f104dd
3c2ba87
bd92113
8249b85
8589ce4
3511c13
a203bde
85098ce
88fe7ca
cf58f6e
d4e92f6
26adfe7
12ae098
1e6d1ab
c488915
b10e2ed
8be790e
9b27c5c
d5b777f
fa4759f
14de743
03e76a1
05a1a37
15a470c
00eb8c9
6718a54
399bf4f
19f0f51
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| const baseConfig = require('./app.json') | ||
|
|
||
| // Determine if this is a development build | ||
| // Development builds use different bundle IDs so they can coexist with production | ||
| const isProduction = | ||
| process.env.EAS_BUILD_PROFILE === 'production' || | ||
| process.env.EXPO_PUBLIC_BUILD_VARIANT === 'PROD' | ||
| const isPreview = | ||
| process.env.EAS_BUILD_PROFILE === 'preview' || | ||
| process.env.EXPO_PUBLIC_BUILD_VARIANT === 'NIGHTLY' | ||
| // Explicitly exclude production and preview builds to prevent dev bundle IDs in production | ||
| const isDevelopment = | ||
| !isProduction && | ||
| !isPreview && | ||
| (process.env.EAS_BUILD_PROFILE === 'development' || | ||
| process.env.EXPO_PUBLIC_BUILD_VARIANT === 'DEV' || | ||
| true) // Default to dev for local builds when neither production nor preview | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Development build logic always evaluates to trueThe |
||
|
|
||
| module.exports = { | ||
| expo: { | ||
| ...baseConfig.expo, | ||
| // Change app name for development builds | ||
| name: isDevelopment ? 'Yoroi Dev' : baseConfig.expo.name, | ||
| ios: { | ||
| ...baseConfig.expo.ios, | ||
| // Use different bundle identifier for development builds | ||
| bundleIdentifier: isDevelopment | ||
| ? 'com.emurgo.yoroi.dev' | ||
| : baseConfig.expo.ios.bundleIdentifier, | ||
| }, | ||
| android: { | ||
| ...baseConfig.expo.android, | ||
| // Use different package name for development builds | ||
| package: isDevelopment | ||
| ? 'com.emurgo.dev' | ||
| : baseConfig.expo.android.package, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Android dev package name inconsistent with iOS patternThe Android development package name |
||
| }, | ||
| }, | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.