Open
Conversation
Add files generated by tree-sitter and deno.
Collaborator
Author
|
To clarify, the original issue #107 requested that the parser supports a generic scoped slot closing tag |
Collaborator
|
Hmm, not sure I really care to support both variants---having the end tag match the start is better for consistency and readability I'll leave it up to @EmranMR if he wants to support this |
Owner
Yup, technically, it should now be possible! but it requires messing about with the I will reopen the issue though, so it is tracked again, and definitely hit it in the future when I get a chance :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #107.
Looks like it was never really properly fixed.
Supports both variants:
Checklist
deno check main/to make sure the source code is finedeno lint main/to utilise the linter. You could also dodeno lint --fix main/to automatically fixdeno run generateensure you include everything in thesrc/*- [ ] Alltests pass in CI
renamed)
STATE_COUNT) >Check the value of STATE_COUNT in src/parser.c it should be
roughly ~5k