Skip to content

Comments

Python - Assignment 2#2

Open
Empress-star wants to merge 3 commits intomainfrom
assignment_two
Open

Python - Assignment 2#2
Empress-star wants to merge 3 commits intomainfrom
assignment_two

Conversation

@Empress-star
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

I have added the requested code and tested that it worked.

What did you learn from the changes you have made?

I had the opportunity to use the numpy methods we learned.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I thought about using file manipulation to adjust the file paths. I did end up using os.path() to show the start of the path to the files, but then I adjusted them by hand.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I had two main issues. At first, I was stumped why there was an undefined variable (summary_values) being returned at the bottom of the patient_summary() function, but then I figured out how to define it with each operation. I then spent about an hour fiddling around with the function because it kept raising errors (first, it told me that data_min didn't have a type, and then it wouldn't apply the methods to the file). I started running individual parts of the code to check if they worked and, at some point, I must have fixed some formatting because it finally worked. I find python to be extremely finicky about formatting compared to SQL.

How were these changes tested?

Once I was done adding code, I reran all the cells and they all worked.

A reference to a related issue in your repository (if applicable)

Checklist

  • [ x] I can confirm that my changes are working as intended

Copy link

@l-mack l-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on assignment 2!

Please note:
Your assignment 2 pull request should only include changes for assignment_2.ipynb, not assignment-1.ipynb from assignment 1.

Please revert these changes by completing the following from your terminal in your assignment 2 directory:

git checkout assignment-2 
git checkout main -- assignment_1.ipynb 
git add assignment_1.ipynb 
git commit -m "Revert assignment_1.ipynb to original version from the main branch" 
git push origin assignment-2

@Empress-star
Copy link
Owner Author

reverted, as requested. Thanks!

@l-mack
Copy link

l-mack commented May 23, 2025

Looks good! I have marked your assignment as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants