Open
Conversation
l-mack
suggested changes
May 14, 2025
l-mack
left a comment
There was a problem hiding this comment.
Great work on assignment 2!
Please note:
Your assignment 2 pull request should only include changes for assignment_2.ipynb, not assignment-1.ipynb from assignment 1.
Please revert these changes by completing the following from your terminal in your assignment 2 directory:
git checkout assignment-2
git checkout main -- assignment_1.ipynb
git add assignment_1.ipynb
git commit -m "Revert assignment_1.ipynb to original version from the main branch"
git push origin assignment-2
Owner
Author
|
reverted, as requested. Thanks! |
|
Looks good! I have marked your assignment as complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I have added the requested code and tested that it worked.
What did you learn from the changes you have made?
I had the opportunity to use the numpy methods we learned.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
I thought about using file manipulation to adjust the file paths. I did end up using os.path() to show the start of the path to the files, but then I adjusted them by hand.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
I had two main issues. At first, I was stumped why there was an undefined variable (summary_values) being returned at the bottom of the patient_summary() function, but then I figured out how to define it with each operation. I then spent about an hour fiddling around with the function because it kept raising errors (first, it told me that data_min didn't have a type, and then it wouldn't apply the methods to the file). I started running individual parts of the code to check if they worked and, at some point, I must have fixed some formatting because it finally worked. I find python to be extremely finicky about formatting compared to SQL.
How were these changes tested?
Once I was done adding code, I reran all the cells and they all worked.
A reference to a related issue in your repository (if applicable)
Checklist