Skip to content

Fix/oscilloscope background load #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nitin710 wants to merge 2 commits into from
Closed

Fix/oscilloscope background load #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7471558
Added check for background file existance
nitin710 Apr 9, 2026
eca3260
bump version to v1.6.2
nitin710 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion EmotiBitOscilloscope/src/ofApp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,16 @@ void ofApp::loadWindowSettings()
string bgPath = xml.getValue("backgroundImagePath", "");
if (!bgPath.empty())
{
background_image_.load(ofToDataPath(bgPath));
//TODO: Add handling of specifying image not in the bin/data directory
ofFile bgImgFile(ofToDataPath(bgPath));
if(bgImgFile.exists())
{
background_image_.load(ofToDataPath(bgPath));
}
else
{
ofLogWarning() << "Image file not found. Please ensure image exists at the provided path. Proceeding without a background image" << std::endl;
}
}
xml.popTag();
}
Expand Down
2 changes: 1 addition & 1 deletion src/ofxEmotiBitVersion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//#include <string>
#include "ofMain.h"

const std::string ofxEmotiBitVersion = "1.16.1";
const std::string ofxEmotiBitVersion = "1.16.2";

static const char SOFTWARE_VERSION_PREFIX = 'v';

Expand Down
Loading