test: add coverage for contacts e2e, logger, sanitization, and turretsService - #704
Merged
Emmy123222 merged 1 commit intoJul 30, 2026
Merged
Conversation
…sService Closes Emmy123222#537, Emmy123222#536, Emmy123222#535, Emmy123222#532. - frontend/e2e/contacts.spec.ts: add/edit/delete a contact, tag-filter narrowing, and invalid-address rejection on the contacts page. - backend/__tests__/logger.test.js: log-level filtering and structured output fields (level, msg, time) for the pino logger. - backend/__tests__/sanitization.test.js: sanitizePublicKey/sanitizeUsername neutralise injection payloads while valid keys, usernames, and unrelated body fields (memo, amount) pass through unchanged. - backend/__tests__/turretsService.test.js: deployTxFunction produces the expected job record, and forged/mismatched signing delegation surfaces as a thrown error (401/400) instead of being silently dropped. Note: contacts.spec.ts is verified via static review and `tsc --noEmit` only, not a live Playwright run — the frontend currently fails to build on main due to an unrelated pre-existing bug (components/Navbar.tsx and two other files call a useTranslation() hook that lib/i18n.ts never exports). Left out of scope here; worth a separate fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Nanle-code is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@covenantalade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Closes #537
Closes #536
Closes #535
Closes #532.
Note: contacts.spec.ts is verified via static review and
tsc --noEmitonly, not a live Playwright run — the frontend currently fails to build on main due to an unrelated pre-existing bug (components/Navbar.tsx and two other files call a useTranslation() hook that lib/i18n.ts never exports). Left out of scope here; worth a separate fix.Summary
Type of change
Related issue
Closes #
Changes
Testing
Screenshots (if UI change)
Checklist
main