Feat/frontend modal format slippage csv - #703
Merged
Emmy123222 merged 3 commits intoJul 29, 2026
Merged
Conversation
QRCodeModal, PaymentStatusModal and QuickSendModal each carried their own backdrop, dialog semantics, Escape handling and (in two of three) a copy of the same focus-trap/focus-return logic. Adds components/Modal.tsx owning all of it, with per-modal behaviour kept as props: overlay/panel classes, backdrop-click and Escape opt-outs (the payment tracker still refuses both until the flow is terminal) and an optional body-scroll lock (quick send). QuickSendModal now gets the focus trap it lacked, and role="dialog" moved from the backdrop onto the panel — its backdrop-click test targets the backdrop directly. Initial focus is set in the effect rather than a rAF, which also fixes the previously failing QRCodeModal focus-trap test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Market orders built a strict-receive path payment whose destination amount was just the input amount, so there was no protection against the price moving. TradeForm now quotes the pair (debounced) via the new fetchStrictSendQuote, shows the expected and minimum received amounts, and lets the user pick a tolerance (0.1/0.5/1% presets or a custom value up to 50%). Submission re-quotes and builds a strict-send path payment whose destMin is the fresh quote reduced by that tolerance, over the quoted path. Amounts in the quote panel go through the shared formatAsset helper (Emmy123222#628). Also corrects two limit-order test expectations that asserted a success message the component never produced. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…23222#616, Emmy123222#628) Emmy123222#628 — utils/format.ts gains formatAssetPrecise/formatXLMPrecise for the full-precision, trailing-zero form the batch total renders by hand today. BatchPaymentForm's total and both RecurringPayments amount labels now use the shared formatters instead of inline string building. Emmy123222#616 — parseBatchRecipientsCSV reads address/amount/memo from a CSV, with an optional (and reorderable) header row and positional fallback. Malformed rows come back flagged rather than dropped, and BatchPaymentForm imports them as failed rows with an inline reason so the valid recipients around them stay sendable. Rows past the 10-recipient cap are reported as skipped. Also fixes the fixture addresses in BatchPaymentForm.test.tsx, which were 59 characters and so failed the suite's own 56-character validity mock. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@nonso7 is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@nonso7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
Related issue
Closes #
Changes
Testing
Screenshots (if UI change)
Checklist
mainCloses #616
Closes #619
Closes #627
Closes #628