Skip to content

Conversation

@gmurphey
Copy link

@gmurphey gmurphey commented Dec 31, 2018

I had misread the documentation when setting this up in our app and used this.element when setting up resize detection. This worked great until 0.4.0 was released and when jQuery was removed. I thought it would be nice if the service was still able to accept an element.

@Gaurav0
Copy link
Collaborator

Gaurav0 commented Jan 23, 2019

@gmurphey Sorry for the delay.

This looks very good!

Can you add a test similar to

test('it triggers an action when target changes sizes', function(assert){
where you pass an element instead of a selector?

@Gaurav0 Gaurav0 self-requested a review January 23, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants