[Test PR] See if fuzzing is working again #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reasons" This reverts commit a661a8a.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| steps: | ||
| - name: Build Fuzzers | ||
| id: build | ||
| uses: google/oss-fuzz/infra/cifuzz/actions/build_fuzzers@master |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
| language: rust | ||
|
|
||
| - name: Run Fuzzers | ||
| uses: google/oss-fuzz/infra/cifuzz/actions/run_fuzzers@master |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
EliahKagan
commented
Jan 18, 2025
There was a problem hiding this comment.
This seems to work, completing three times reporting success and with nothing particularly alarming jumping out in the logs. But I think it's not quite equivalent to how it works when it's a PR on the upstream repository. I'll close this and open a PR there, and see how the CI run goes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a.k.a. Revert "deactivate fuzzing as it's not building anymore for unrelated reasons"
Like #1, this is a fork-internal PR for testing fuzzing.
There, it was necessary to open a PR on the upstream repo, in order to test whether a change to the code here would help, since the job won't actually check out and use code from a PR whose base branch (target) is in a fork. But so far, here, I'm mainly testing whether the problem has gone away by itself due to a new nightly Rust toolchain, so it might not end up being necessary to open an investigatory PR upstream before knowing if things are likely to work.
This reverts commit a661a8a.
By the way, the automated CodeQL review comments are due to another thing I'm testing out in this fork: experimental CodeQL scanning for GitHub Actions workflows. There are tradeoffs associated with pinning all actions at specific commit hashes, and I am unsure if that is really a better approach overall for GitoxideLabs/gitoxide. But that's what the comments are recommending. Those comments are conceptually unrelated to what I am trying to test here.