Add back optimizer-aware gradients #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciaquirke
force-pushed
the
add-normalizers
branch
from
437b9cd to
0e2fdd3
Compare
luciaquirke
force-pushed
the
add-normalizers
branch
6 times, most recently
from
6dff943 to
40a4602
Compare
Contributor
|
Does this have the bias fixes that Baber did in #76 ? Or what is the relation between this branch and his? Rest LGTM |
Collaborator
Author
It does not have any relation, and this issue still needs to be fixed. I don't think Baber's PR is merge ready, so I think this is an outstanding bug. I will make an issue for the bug. |
luciaquirke
force-pushed
the
add-normalizers
branch
from
b7fbe98 to
833678c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear why these were removed, adding back to complete the TrackStar replication feature set.