Fix bkpr-listincome start_time and end_time for consolidated onchain fees, too. #8624
+44
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… events. Signed-off-by: Rusty Russell <[email protected]>
…idated_fees. If the fees are not *all* of the fees (as we do in next patch), the query would be wrong. Plus, as the FIXME suggests, we should just save it as we're getting the fee_sums, not do a whole new query! Signed-off-by: Rusty Russell <[email protected]>
Fixes: ElementsProject#8318 Reported-by: Shahaha Changelog-Fixed: Plugins: `bkpr_listincome` now honors `start_time` and `end_time` parameters for onchain fees.
rustyrussell
force-pushed
the
guilt/bkpr-fix-onchain-timebox
branch
from
c75880b to
89a56bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8318