xpay below minimum htlc amount should not give up #8057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_minimum. Signed-off-by: Rusty Russell <[email protected]>
In particular, if the total amount we're sending is less than the minimum amount the channel insists on, we can eliminate it. This fixes the problem that we're really trying to send a de-minumus amount (rather than the more obscure case where we divide the amount and then it is below the minimum). After trying several other approaches, this was by far the cleanest! Reported-by: https://github.com/JssDWt Fixes: ElementsProject#8045 Changelog-Fixed: xpay: don't simply give up if our total amount is less than htlc_minimum_msat on some channel. Signed-off-by: Rusty Russell <[email protected]>
Lagrang3
approved these changes
Feb 6, 2025
|
I like the fix, but this causes a broken message when explaining the route failure while running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excellent bug report, simple fix.