Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: 'channel_closed' notification type #8048

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NishantBansal2003
Copy link

@NishantBansal2003 NishantBansal2003 commented Feb 3, 2025

Ref: #3207 #3662

PR Description

This adds a new notification type: channel_closed.

This notification is emitted if a channel has been successfully closed with a peer and sends the peer's ID and the closing transaction ID.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

Changelog-Added: a new 'channel_closed' notification type
is added, which is emitted when a channel has
been successfully closed with a peer.

Signed-off-by: Nishant Bansal <[email protected]>
Changelog-None

Signed-off-by: Nishant Bansal <[email protected]>
@NishantBansal2003
Copy link
Author

Although the channel closure state can currently be notified via channel_state_changed, it would be more symmetrical to have a dedicated channel_closed event analogous to the channel_opened event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant