Splice: Interop Final (probably) with Eclair #8021
Open
+474
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@remyers reported this fix made his splice interop test pass! 🎉🚀 |
ddustin
changed the title
ddustin
changed the title
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
from
e86bfbc to
facfeeb
Compare
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
9 times, most recently
from
29d52d1 to
45ae772
Compare
niftynei
reviewed
Feb 4, 2025
| @@ -200,6 +200,7 @@ new_inflight(struct channel *channel, | |||
|
|
|||
| inflight->i_am_initiator = i_am_initiator; | |||
| inflight->force_sign_first = force_sign_first; | |||
| inflight->is_locked = false; | |||
| inflight->splice_locked_memonly = false; | |||
There was a problem hiding this comment.
it'd be great to add this to wallet/tests/run-wallet.c for the inflights
| @@ -3829,7 +3829,7 @@ static void splice_accepter(struct peer *peer, const u8 *inmsg) | |||
| new_inflight->remote_funding = peer->splicing->remote_funding_pubkey; | |||
| new_inflight->outpoint = outpoint; | |||
| new_inflight->amnt = both_amount; | |||
| new_inflight->psbt = tal_steal(new_inflight, ictx->current_psbt); | |||
| new_inflight->psbt = clone_psbt(new_inflight, ictx->current_psbt); | |||
There was a problem hiding this comment.
yeah tal_steal and psbt code aren't good friends
There was a problem hiding this comment.
No more theft among psbt 🙅
|
|
||
| if (!fromwire_splice_locked(msg, &chanid)) | ||
| if (!fromwire_splice_locked(msg, &chanid, &splice_txid)) |
There was a problem hiding this comment.
Added a check for it in e117ec4
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
3 times, most recently
from
e117ec4 to
e91b6b7
Compare
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
4 times, most recently
from
8907321 to
728c339
Compare
Interop testing with Eclair revealed an issue with remote funding key rotation. This searches for the funding output using the rotated remote funding pubkey instead of the furrent funding pubkey. Also update the variable name to be more clear which this represents. Changelog-Changed: Interop fixes for compatability with Eclair
This is needed to remember if a splice was locked and reconnect occurs mid `splice_locked` attempted so it can be resumed in reestablish.
This field should be serialized for communication between channeld and lightningd.
To support resuming `splice_locked` across channel reconnect, we need to pass inflight `is_locked` between lightningd and channeld. This implements that interface between channeld and lightningd so each inflight should have up to date `is_locked` values between restarts.
Use the inflight information to set a correct `locked_txid` value on restart. This is critical for handling interrupted `splice_locked` events that need to be resumed on reconnect/reestablish.
A new case where `splice_locked` must be sent again on reestablish. This handles the case where `splice_locked` did not complete locally or remotely and must be resumed.
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
10 times, most recently
from
b7f85d1 to
80fc38d
Compare
PSBT changeset routines were using linearize_output which mutated the memory of the objects it was comparing. This commit fixes that and also cleans up the memory usage to be more clear and more guarentee there is no memory corruption. Changelog-None
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
from
80fc38d to
a20f2ef
Compare
Update splice flows to use the new `clone_psbt` method instead of stealing back and forth.
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
14 times, most recently
from
8def35d to
c41c880
Compare
ddustin
force-pushed
the
ddustin/splice_interop_final_(probably)
branch
from
c41c880 to
324a890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interop testing with Eclair revealed an issue with remote funding key rotation.
This searches for the funding output using the rotated remote funding pubkey instead of the current funding pubkey.
Update the variable name to be more clear which this represents.
Implement new pending spec changes for
splice_lockedresuming in reestablish.Fixes #8030