Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: generate and install requirements.txt files for Python plugins #7864

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Makefile: generate and install requirements.txt files for Python plugins #7864

wants to merge 2 commits into from

Conversation

rustyrussell
Copy link
Contributor

Doesn't automate the install, but at least provides some tools for users to install the requirements on their systems

See-also: #7665

@vincenzopalazzo vincenzopalazzo force-pushed the install-requirements.txt-file branch from d7ad639 to 17722fd Compare November 24, 2024 09:59
vincenzopalazzo
vincenzopalazzo approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 17722fd

Modified the commit body to make the CI happy, now lets wait the CI

@vincenzopalazzo
Copy link
Contributor

some of the CI failure liek the mac os looks like unrelated

tools/generate-wire.py --page impl tools/test/test_gen.h test_type < tools/test/test_cases > tools/test/test_gen.c
echo '#include "test_gen.h"' > tools/test/print_gen.c
tools/generate-wire.py -P --page impl tools/test/print_gen.h test_type < tools/test/test_cases >> tools/test/print_gen.c
xgettext plugins/bkpr/statements_gettextgen.po
sql-rewrite plugins/bkpr/db_sqlite3_sqlgen.c
sql-rewrite plugins/bkpr/db_postgres_sqlgen.c
genidx doc/index.rst
cd plugins/wss-proxy && poetry export --without-hashes > ../../plugins/wss-proxy-requirements.txt
/bin/sh: poetry: command not found
rm external/build-arm64-apple-darwin23.6.0/libwally-core-build/src/secp256k1/libsecp256k1.la
make: *** [plugins/wss-proxy-requirements.txt] Error 127

@rustyrussell rustyrussell added this to the v25.02 milestone Nov 26, 2024
@rustyrussell rustyrussell force-pushed the install-requirements.txt-file branch from 17722fd to ae6fab1 Compare February 6, 2025 02:58
@rustyrussell
Copy link
Contributor Author

Rebased on master: wss is now the only Python plugin!

@rustyrussell rustyrussell force-pushed the install-requirements.txt-file branch from ae6fab1 to b3a4cbf Compare February 6, 2025 03:00
@rustyrussell
Makefile: include POETRY variable to allow for local overrides.
1b41743 
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell
Makefile: generate and install requirements.txt files for Python plug…
aee36cc 
…ins.

Doesn't automate the install, but at least provides some tools for users
to install the requirements on their systems

Changelog-Added: Install: we now supply requirements.txt file for Python plugin (i.e. wss-proxy).
See-also: ElementsProject#7665
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell rustyrussell force-pushed the install-requirements.txt-file branch from b3a4cbf to aee36cc Compare February 6, 2025 04:20
vincenzopalazzo
vincenzopalazzo approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v25.02
Development

Successfully merging this pull request may close these issues.
2 participants
@rustyrussell @vincenzopalazzo