-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upload geojson feature for use in search #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filed #201 about error handling. |
1 task
philvarner
reviewed
Jul 14, 2023
philvarner
reviewed
Jul 14, 2023
philvarner
reviewed
Jul 14, 2023
philvarner
approved these changes
Jul 14, 2023
Advanced menu is behind scene modal has been correctly z ordered per #200 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Proposed Changes:
To test:
test cancel
VITE_ADVANCED_SEARCH_ENABLED
to true in configUpload geojson
buttoncancel
button in modaltest adding files
happy paths:
test point
Upload geojson
buttontest_geojson/valid_point.geojson
add
buttonclear
buttontest other files in the
test_geojson
directory that start withvalid_
test drag
tests for invalid uploads:
test no file
Upload geojson
buttonadd
buttonNo file selected
add
button againX
button on the right side of the error messagetest invalid file type
Upload geojson
buttontest_geojson/invalid_exampleImageFile.png
ERROR: Only .json or .geojson supported
test exceeded file size
Upload geojson
buttontest_geojson/invalid_fileTooLarge.geojson
ERROR: File size exceeded (100KB max)
test json structure not valid
Upload geojson
buttontest_geojson/invalid_jsonStructureNotValid.geojson
add
buttonERROR: Invalid geojson uploaded
test geojson structure not valid
Upload geojson
buttontest_geojson/invalid_MissingType.geojson
add
buttonERROR: Invalid geojson uploaded
test geometry collection uploaded (not allowed)
Upload geojson
buttontest_geojson/invalid_geometryCollection.geojson
add
buttonERROR: GeometryCollection not supported
PR Checklist: