This repository was archived by the owner on Apr 24, 2024. It is now read-only.
Conversation
badnames
force-pushed
the
fix/groups_instead_of_layers
branch
from
November 16, 2023 16:50
2ee8201 to
7cc5885
Compare
Member
Author
|
jenkins build please |
markus2330
approved these changes
Nov 20, 2023
markus2330
left a comment
Contributor
There was a problem hiding this comment.
CI fails. Probably better to merge this after release, as it received no testing yet?
Member
Author
|
jenkins build please |
Contributor
|
@4ydan do you know why this e2e test fails? |
Contributor
|
It looks like the whole page crashed on the test. Yes, trying to select a plant with a select box crashes the application. |
Contributor
|
It is not release critical, so let us debug this later. |
Contributor
|
@badnames pls rebase and set as ready to merge |
Contributor
|
The cursor layer needs to be commented out, otherwise e2e will fail. |
# Conflicts: # frontend/src/features/map_planning/layers/plant/PlantsLayer.tsx
Contributor
|
Unfortunately still fails. |
Member
Author
|
#1224 is the updated branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basics
close #X, are in the commit messages and changelog.Checklist
Review