Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Use Konva groups instead of layers. - #1056

Closed
badnames wants to merge 14 commits into
masterfrom
fix/groups_instead_of_layers
Closed

badnames wants to merge 14 commits into
masterfrom
fix/groups_instead_of_layers

Conversation

@badnames

@badnames badnames commented Nov 12, 2023

Copy link
Copy Markdown
Member

Basics

  • I added a line to changelog.md
  • The PR is rebased with current master.
  • Details of what you changed are in commit messages.
  • References to issues, e.g. close #X, are in the commit messages and changelog.
  • The buildserver is happy.

Checklist

  • I have installed and I am using pre-commit hooks
  • I fully described what my PR does in the documentation
  • I fixed all affected documentation
  • I fixed the introduction tour
  • I wrote migrations in a way that they are compatible with already present data
  • I fixed all affected decisions
  • I added automated tests or a manual test protocol
  • I added code comments, logging, and assertions as appropriate
  • I translated all strings visible to the user
  • I mentioned every code or binary not directly written or done by me in reuse syntax
  • I created left-over issues for things that are still to be done
  • Code is conforming to our Architecture
  • Code is conforming to our Guidelines
  • Code is consistent to our Design Decisions
  • Exceptions to any guidelines are documented

Review

  • I've tested the code
  • I've read through the whole code
  • I've read through the whole documentation
  • I've checked conformity to guidelines

@badnames
badnames force-pushed the fix/groups_instead_of_layers branch from 2ee8201 to 7cc5885 Compare November 16, 2023 16:50
@badnames
badnames requested a review from markus2330 November 19, 2023 21:11
@badnames

Copy link
Copy Markdown
Member Author

jenkins build please

@markus2330 markus2330 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails. Probably better to merge this after release, as it received no testing yet?

Comment thread frontend/src/features/map_planning/utils/ShapesSelection.ts Outdated
@badnames

Copy link
Copy Markdown
Member Author

jenkins build please

@markus2330

Copy link
Copy Markdown
Contributor

@4ydan do you know why this e2e test fails?

@4ydan

4ydan commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

It looks like the whole page crashed on the test.

Yes, trying to select a plant with a select box crashes the application.

@markus2330

Copy link
Copy Markdown
Contributor

It is not release critical, so let us debug this later.

@markus2330

Copy link
Copy Markdown
Contributor

@badnames pls rebase and set as ready to merge

@markus2330

Copy link
Copy Markdown
Contributor

The cursor layer needs to be commented out, otherwise e2e will fail.

markus2330 and others added 2 commits December 4, 2023 07:02
# Conflicts:
#	frontend/src/features/map_planning/layers/plant/PlantsLayer.tsx
@markus2330

Copy link
Copy Markdown
Contributor

Unfortunately still fails.

@badnames

Copy link
Copy Markdown
Member Author

#1224 is the updated branch

@badnames badnames closed this Mar 29, 2024
@badnames
badnames deleted the fix/groups_instead_of_layers branch March 29, 2024 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants