sql reformatting

[markus2330]

Describe the Bug

To include this in CI, we will need to fix all these errors first.

Steps to Reproduce the Problem

root folder of the project

pre-commit run sqlfluff-fix -a

Expected Result

✔️

Actual Result

FAIL

PermaplanT version

master

Operating System

devcontainer rust:1.67.1-slim image

Browser

Versions of other relevant software/extensions

Additional info/logs

[temmey]

pr #765

[4ydan]

To sumup my thoughts quick.
For CI it would be best to run two separate hooks if I understand the issue correctly.

pre-commit run hook1 -a
pre-commit run hook2 -a

If one hook will always throw errors/warnings we will need to make sure to ignore the always thrown errors/warnings, maybe with downgrading or some other methods provided by sqlfluff to make sure real errors dont sneak through.

We have also the possiblity to write a hook in pre-commit that is ignored when running pre-commit locally but can be executed manually inside CI like this:

pre-commit run --hook-stage manual manualhook -a

If this helps in any way.

PermaplanT/ci/Jenkinsfile

Line 103 in f1f26ab

sh "pre-commit run --hook-stage manual codespell -a"

Appending the hooks after this hook would include them fully to CI.

[markus2330]

I still think it would be best if we find a way to fix the problem within pre-commit. It is not ideal if manual sequences are required (even if they can be put into CI). What about our own hook in pre-commit that executes sqlfluff two times?

Alternatively, I still think it is okay that integer etc. is lower-case. This would solve all the troubles the easiest way, won't it?