Add management of 'NIN' comparison operator

Elastic-Suite · Feb 14, 2025 · 02b3815 · 02b3815
1 parent df8e6ae
commit 02b3815
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/Search/ExpressionVisitor.php b/src/Search/ExpressionVisitor.php
@@ -157,7 +157,7 @@ public function walkComparison(Comparison $comparison, bool $isStitchedQuery = f
         [$type, $field, $comeFromFacet] = $this->explodeFieldTypeName($comparison->getField());
         $value = $this->dispatch($comparison->getValue(), $isStitchedQuery);
         $operator = $this->getGallyOperator($comparison->getOperator());
-        $hasNegation = str_starts_with($comparison->getOperator(), 'NOT') || '<>' === $comparison->getOperator();
+        $hasNegation = str_starts_with($comparison->getOperator(), 'NOT') || \in_array($comparison->getOperator(), ['<>', 'NIN'], true);
 
         if ('all_text' === $field) {
             $this->searchQuery = $value;
@@ -281,7 +281,7 @@ private function explodeFieldTypeName(string $field): array
     private function getGallyOperator(string $operator): string
     {
         return match ($operator) {
-            'IN', 'NOT IN' => Request::FILTER_OPERATOR_IN,
+            'IN', 'NOT IN', 'NIN' => Request::FILTER_OPERATOR_IN,
             'LIKE', 'NOT LIKE' => Request::FILTER_OPERATOR_MATCH,
             'EXISTS', 'NOT EXISTS' => Request::FILTER_OPERATOR_EXISTS,
             '>' => Request::FILTER_OPERATOR_GT,

diff --git a/src/Tests/Search/ExpressionVisitorTest.php b/src/Tests/Search/ExpressionVisitorTest.php
@@ -63,6 +63,14 @@ protected function dispatchTestDataProvider(): iterable
                 ],
             ],
         ];
+        yield [
+            new Comparison('type', 'NIN', new Value(['configurable', 'kit'])),
+            [
+                'queryFilters' => [
+                    ['boolFilter' => ['_not' => [['equalFilter' => ['field' => 'type', 'in' => ['configurable', 'kit']]]]]],
+                ],
+            ],
+        ];
         yield [
             new Comparison('sku', '=', new Value('test')),
             [