Changes required to unbreak vite-rolldown #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request contains changes to this plugin so that running vite with rolldown still works. I believe we're not inserting the correct entries into
rolldownOptions
causing us to run into this issue: vitejs/rolldown-vite#371Background 📜
Since rolldown-vite expects
rolldownOptions
instead ofrollupOptions
and somehow both are present when the plugin in the current state is run,rollupOptions
gets discarded, which means all the settings built up from theconfig
function get dropped (e.g entrypoints)The Fix 🔨
This fix detects whether we're using rolldown and sets the options appropriately. In addition, I attempted to fix an issue where
outputFileName
was being passed an undefined value , causing vite to fail building assets. Once I addedif (typeof name === "undefined") return "";
- everything started building again.