fix(core): prevent duplicate graph node IDs from crashing graph views - #610
Open
KumamuKuma wants to merge 4 commits into
Open
fix(core): prevent duplicate graph node IDs from crashing graph views#610KumamuKuma wants to merge 4 commits into
KumamuKuma wants to merge 4 commits into
Conversation
Contributor
Author
|
@Lum1104 Please help check this pr, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateGraphboundary, preserving the first valid node and reporting later duplicates as droppedcontainsedges are skipped togetherRoot cause
Java overloads are correctly emitted as separate structural entries, but
GraphBuilderderives node IDs from only the file path and bare method name. The legacy structural loops inserted every entry without checking the shared ID set.validateGraphthen accepted every schema-valid duplicate, allowing repeated React Flow node IDs/keys to reach the third-level expansion and crash React reconciliation on click.This hotfix intentionally keeps the existing name-based ID schema and applies deterministic first-wins behavior. Representing every overload separately would require a broader signature/owner ID migration and call-edge compatibility work.
Validation
pnpm lintFixes #536