Fixes & improvements

- Fixes a warning regarding odg if the default guides were already backed up (files not being able to move, expected behavior) - Bound escape to destroy the info windows
Egezenn · Feb 22, 2025 · 9dcef19 · 9dcef19
1 parent 277c958
commit 9dcef19
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/gui.pyw b/gui.pyw
@@ -455,15 +455,20 @@ class App:
                                         exist_ok=True,
                                     )
                                     for name in os.listdir(mpaths.itembuilds_dir):
-                                        if name != "bkup":
-                                            os.rename(
-                                                os.path.join(
-                                                    mpaths.itembuilds_dir, name
-                                                ),
-                                                os.path.join(
-                                                    mpaths.itembuilds_dir, "bkup", name
-                                                ),
-                                            )
+                                        try:
+                                            if name != "bkup":
+                                                os.rename(
+                                                    os.path.join(
+                                                        mpaths.itembuilds_dir, name
+                                                    ),
+                                                    os.path.join(
+                                                        mpaths.itembuilds_dir,
+                                                        "bkup",
+                                                        name,
+                                                    ),
+                                                )
+                                        except FileExistsError:
+                                            pass  # backup was created and opendotaguides was replacing the guides already
                                     shutil.unpack_archive(
                                         zip_path, temp_dump_path, "zip"
                                     )
@@ -477,6 +482,8 @@ class App:
                                     print(
                                         "→ Replaced default guides with OpenDotaGuides guides."
                                     )
+                                    if os.path.exists(zip_path):
+                                        os.remove(zip_path)
                                 else:
                                     print(
                                         "→ Failed to download latest OpenDotaGuides guides."

diff --git a/helper.py b/helper.py
@@ -87,6 +87,7 @@ def modInfo(widget, name, mod_path, event):
         height=1,
         width=10,
     )
+    infoWindow.bind("<Escape>", lambda e: infoWindow.destroy())
     close_button.grid(row=1, column=0, pady=5)