Repository navigation
Remove temporary Slack fixture capture - #188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Remove the temporary EFF-3709 Slack fixture capture, its channel filter and envelope-token scrubber. Signature/workspace/app validation, normal bot responses and reaction handling are unchanged. Replace capture-specific tests with a signed-webhook regression proving the former capture channel emits no logs while messages, mentions and reactions still reach sessions.
Deployment authorization
Hold released by Team Lead on 2026-11-12 after Nelson pushed the required non-deferred captures in Effect commit f66a72895770a1e621709c4260828709fedf565f and independent review approved this cleanup at bdc142f. All four PR checks passed. Main automatically deploys after Check succeeds. This authorization does not cover merging Effect PR #10581.
Validation
nix develop -c pnpm exec vp check: zero errors (2001 warnings).--maxWorkers 1: 120 tests.Closes EFF-3694
This PR covers only the janitor cleanup tracked on that issue, not the adapter delivery in Effect PR #10581.