fix(Logger): Support Cloudflare Workers by avoiding console.group when in workerd #5429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in workerd - Add workerd runtime detection using navigator.userAgent === 'Cloudflare-Workers' - Modify prettyLoggerTty to skip console.group/groupEnd in workerd (similar to Bun) - Modify prettyLoggerBrowser to use flat logging instead of console.groupCollapsed in workerd - Fixes missing log messages in Cloudflare Workers where console.group methods are no-ops Resolves Effect-TS#5398
🦋 Changeset detectedLatest commit: 434e834 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… browser logger - Detect workerd as TTY environment using shouldUseTTYMode logic - Route workerd to TTY logger which already has console.group detection - Keep browser logger unchanged for actual browser environments - Add changeset documenting the fix
- Reuse module-level isWorkerd constant instead of redefining in prettyLoggerTty - Cleaner code with single source of truth for workerd detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the pretty logger for Cloudflare Workers where
console.group/console.groupCollapsedare no-ops, causing log messages to disappear.Problem
In Cloudflare Workers (workerd runtime):
console.group(),console.groupCollapsed(), andconsole.groupEnd()are no-opsLogger.prettytries to use these methods, the first log message gets "consumed" by the no-op call and disappearsEffect.log()callsSolution
navigator.userAgent === 'Cloudflare-Workers'prettyLoggerTtyto skipconsole.group()calls in workerd (similar to existing Bun handling)prettyLoggerBrowserto use flat logging instead ofconsole.groupCollapsed()in workerdTesting
Tested with a Cloudflare Worker using the modified Effect logger:
Effect.log("First", "second", "third")Effect.log("Single test")Related Issues
Closes #5398
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]