Skip to content

Conversation

@unknown
Copy link
Contributor

@unknown unknown commented Dec 5, 2025

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fixes HttpServerResponse.empty ignoring options.headers and options.cookies. By fixing this, it resolves a bug where the CORS middleware does not properly set response headers.

return Effect.succeed(Response.empty({
status: 204,
headers: headersFromRequestOptions(request)
}))

Related

  • Related Issue #
  • Closes #

@unknown unknown changed the title Fix Response.empty ignoring options Fix HttpServerResponse.empty ignoring options Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Bundle Size Analysis

File Name Current Size Previous Size Difference
bundle/basic.ts 6.13 KB 6.13 KB 0.00 KB (0.00%)
bundle/batching.ts 8.38 KB 8.38 KB 0.00 KB (0.00%)
bundle/brand.ts 6.32 KB 6.32 KB 0.00 KB (0.00%)
bundle/cache.ts 9.45 KB 9.45 KB 0.00 KB (0.00%)
bundle/config.ts 16.19 KB 16.19 KB 0.00 KB (0.00%)
bundle/differ.ts 14.04 KB 14.04 KB 0.00 KB (0.00%)
bundle/http-client.ts 18.45 KB 18.45 KB 0.00 KB (0.00%)
bundle/logger.ts 8.58 KB 8.58 KB 0.00 KB (0.00%)
bundle/metric.ts 8.62 KB 8.62 KB 0.00 KB (0.00%)
bundle/optic.ts 7.58 KB 7.58 KB 0.00 KB (0.00%)
bundle/pubsub.ts 12.96 KB 12.96 KB 0.00 KB (0.00%)
bundle/queue.ts 10.86 KB 10.86 KB 0.00 KB (0.00%)
bundle/schedule.ts 9.30 KB 9.30 KB 0.00 KB (0.00%)
bundle/schema-arbitrary.ts 16.18 KB 16.18 KB 0.00 KB (0.00%)
bundle/schema-equivalence.ts 15.31 KB 15.31 KB 0.00 KB (0.00%)
bundle/schema-formatter.ts 15.26 KB 15.26 KB 0.00 KB (0.00%)
bundle/schema-json-schema.ts 14.69 KB 14.69 KB 0.00 KB (0.00%)
bundle/schema-record-literals-key.ts 13.66 KB 13.66 KB 0.00 KB (0.00%)
bundle/schema-string-async.ts 11.19 KB 11.19 KB 0.00 KB (0.00%)
bundle/schema-string-check.ts 9.95 KB 9.95 KB 0.00 KB (0.00%)
bundle/schema-string.ts 9.53 KB 9.53 KB 0.00 KB (0.00%)
bundle/schema-template-literal.ts 12.08 KB 12.08 KB 0.00 KB (0.00%)
bundle/schema-toSerializerStringTree.ts 15.07 KB 15.07 KB 0.00 KB (0.00%)
bundle/schema.ts 14.79 KB 14.79 KB 0.00 KB (0.00%)
bundle/stm.ts 11.68 KB 11.68 KB 0.00 KB (0.00%)
bundle/stream.ts 8.31 KB 8.31 KB 0.00 KB (0.00%)

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

📊 JSDoc Documentation Analysis

📈 Current Analysis Results
Analyzing 66 TypeScript files in packages/effect/src/ (including schema and config subdirectories)...

============================================================
         EFFECT JSDOC ANALYSIS REPORT
============================================================

📊 SUMMARY STATISTICS
------------------------------
Total files analyzed: 66
Total exported members: 2191
Missing @example: 1065 (48.6%)
Missing @category: 385 (17.6%)

🎯 TOP FILES NEEDING ATTENTION
----------------------------------------
1. schema/Schema.ts
   📝 420 missing examples, 🏷️  240 missing categories
   📦 420 total exports
2. schema/AST.ts
   📝 71 missing examples, 🏷️  13 missing categories
   📦 71 total exports
3. schema/Annotations.ts
   📝 37 missing examples, 🏷️  25 missing categories
   📦 37 total exports
4. schema/StandardSchema.ts
   📝 27 missing examples, 🏷️  27 missing categories
   📦 27 total exports
5. schema/Getter.ts
   📝 52 missing examples, 🏷️  1 missing categories
   📦 52 total exports
6. schema/Transformation.ts
   📝 28 missing examples, 🏷️  17 missing categories
   📦 28 total exports
7. PubSub.ts
   📝 25 missing examples, 🏷️  16 missing categories
   📦 37 total exports
8. Config.ts
   📝 33 missing examples, 🏷️  5 missing categories
   📦 33 total exports
9. Cause.ts
   📝 28 missing examples, 🏷️  2 missing categories
   📦 69 total exports
10. schema/FromJsonSchema.ts
   📝 15 missing examples, 🏷️  15 missing categories
   📦 15 total exports
11. Effect.ts
   📝 27 missing examples, 🏷️  1 missing categories
   📦 230 total exports
12. SynchronizedRef.ts
   📝 24 missing examples, 🏷️  0 missing categories
   📦 24 total exports
13. schema/Issue.ts
   📝 22 missing examples, 🏷️  2 missing categories
   📦 22 total exports
14. schema/Parser.ts
   📝 24 missing examples, 🏷️  0 missing categories
   📦 24 total exports
15. ConfigProvider.ts
   📝 21 missing examples, 🏷️  1 missing categories
   📦 21 total exports

✅ PERFECTLY DOCUMENTED FILES
-----------------------------------
   Clock.ts (5 exports)
   Console.ts (21 exports)
   FiberHandle.ts (15 exports)
   FiberMap.ts (19 exports)
   FiberSet.ts (14 exports)
   Match.ts (57 exports)
   MutableRef.ts (17 exports)
   Random.ts (7 exports)
   RegExp.ts (3 exports)
   Runtime.ts (3 exports)
   Schedule.ts (49 exports)
   Symbol.ts (1 exports)
   index.ts (0 exports)
   schema/index.ts (0 exports)

🔍 SAMPLE MISSING ITEMS FROM schema/Schema.ts
-----------------------------------
   Optionality (type, line 54): missing example, category
   Mutability (type, line 61): missing example, category
   ConstructorDefault (type, line 68): missing example, category
   MakeOptions (interface, line 76): missing example, category
   Bottom (interface, line 100): missing example, category
   declareConstructor (interface, line 180): missing example, category
   declareConstructor (function, line 204): missing example
   declare (interface, line 228): missing example
   declare (function, line 237): missing example, category
   revealBottom (function, line 257): missing example, category

📋 BREAKDOWN BY EXPORT TYPE
-----------------------------------
type: 128 missing examples, 74 missing categories
const: 392 missing examples, 101 missing categories
interface: 206 missing examples, 137 missing categories
class: 54 missing examples, 3 missing categories
function: 254 missing examples, 52 missing categories
namespace: 31 missing examples, 18 missing categories

📈 DOCUMENTATION PROGRESS
------------------------------
Examples: 1126/2191 (51.4% complete)
Categories: 1806/2191 (82.4% complete)

============================================================
Analysis complete! 1450 items need attention.
============================================================

📄 Detailed results saved to: jsdoc-analysis-results.json

This comment is automatically updated on each push. View the analysis script for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant