Skip to content

Change parameter name #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change parameter name #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d6872
Change parameter name
Nov 27, 2024
7fa8bf8
Correct UpdateEnvironment
Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/edgio_api/edgio_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ func (c *EdgioClient) UpdateEnvironment(environmentID, name string, onlyMaintain
"name": name,
// as can_members_deploy is depricated, but update api is not
// we need to use it to map onlyMaintainersCanDeploy
"can_members_deploy": !onlyMaintainersCanDeploy,
"only_maintainers_can_deploy": onlyMaintainersCanDeploy,
"http_request_logging": httpRequestLogging,
"preserve_cache": preserveCache,
Expand Down
4 changes: 2 additions & 2 deletions internal/integration_tests/environment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func TestEnvironment_Lifecycle(t *testing.T) {
})
}

func getEnvConfig(clientID, clientSecret, organizationID, propertySlug, envName string, canMembersDeploy, httpRequestLogging bool) string {
func getEnvConfig(clientID, clientSecret, organizationID, propertySlug, envName string, onlyMaintainersCanDeploy, httpRequestLogging bool) string {
return fmt.Sprintf(`
provider "edgio" {
client_id = "%s"
Expand All @@ -68,5 +68,5 @@ func getEnvConfig(clientID, clientSecret, organizationID, propertySlug, envName
name = "%s"
only_maintainers_can_deploy = %t
http_request_logging = %t
}`, clientID, clientSecret, organizationID, propertySlug, envName, canMembersDeploy, httpRequestLogging)
}`, clientID, clientSecret, organizationID, propertySlug, envName, onlyMaintainersCanDeploy, httpRequestLogging)
}