Sam/infinite ramp plugin #5715
Draft
Sam/infinite ramp plugin #5715
+5,974
−314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/app.ts
Outdated
|
|
||
| // Uncomment the next line to remove popup warning/error boxes. | ||
| // LogBox.ignoreAllLogs() | ||
| LogBox.ignoreAllLogs() |
There was a problem hiding this comment.
Bug: Debugging Code Left Enabled
LogBox.ignoreAllLogs() was uncommented, suppressing all React Native warnings and errors. This appears to be debugging code accidentally left enabled, which makes debugging much harder, particularly in production. The preceding comment indicates this line should typically remain commented out.
| ) | ||
| if (token == null) return { supported: false } | ||
| currencyCode = token.currencyCode | ||
| } |
There was a problem hiding this comment.
Bug: Token Support Validation Uses Incorrect Wallet
In checkSupport, the code arbitrarily picks the first wallet from account.currencyWallets instead of finding one that matches cryptoAsset.pluginId. This can cause incorrect token support validation, as the currencyConfig from an unrelated wallet might be used.
samholmes
force-pushed
the
sam/infinite-ramp-plugin
branch
4 times, most recently
from
2311b66 to
9ebe8d3
Compare
Jon-edge
force-pushed
the
sam/infinite-ramp-plugin
branch
from
9ebe8d3 to
973a035
Compare
Jon-edge
force-pushed
the
sam/infinite-ramp-plugin
branch
from
4a14ce2 to
00f5b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: