Cleanup in prep for New Architecture #4996
Draft
+305
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/new-arch
branch
from
e25947d to
3338cf0
Compare
swansontec
force-pushed
the
william/new-arch
branch
from
3338cf0 to
6872811
Compare
This reverts commit 2e02f76.
React Native crashes when fontSize is 0 or negative. Added safeFontSize utility to ensure minimum fontSize of 1 pixel. Fixed potentially dangerous calculations in IconBadge, FilledTextInput, FiatIcon, and ThemedIcons components.
samholmes
force-pushed
the
william/new-arch
branch
from
6872811 to
b659e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: