Skip to content

Zano - Add multi output support #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented May 19, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/react-native-zano#5

Description

none

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs one small change, but I'll approve it.

asCodec,
asNumber,
asObject,
asOptional,
asString,
Cleaner
} from 'cleaners'
import { TransferParams } from 'react-native-zano'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import type, just to be extra safe. If we import any actual code, it'll blow up the build.

We shouldn't use the confirmations field without updating the rest of the engine. Allow the core to handle it for now.
@peachbits peachbits force-pushed the matthew/zano-multi-target branch from a3c7964 to b92a52c Compare May 26, 2025 19:04
@peachbits peachbits force-pushed the matthew/zano-multi-target branch from b92a52c to 4f5ba66 Compare May 26, 2025 19:05
@peachbits peachbits enabled auto-merge May 26, 2025 19:06
@peachbits peachbits merged commit 1c08069 into master May 26, 2025
2 checks passed
@peachbits peachbits deleted the matthew/zano-multi-target branch May 26, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants