Add getTokenDetails to EVM and Zano
#936
Merged
+156
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
force-pushed
the
matthew/get-asset-details
branch
from
7845b08 to
7ab0762
Compare
6 tasks
swansontec
approved these changes
May 19, 2025
| const { contractAddress } = filter | ||
| if (contractAddress == null) return [] | ||
|
|
||
| const valid = EthereumUtil.isValidAddress(contractAddress) |
There was a problem hiding this comment.
Question: do we need to do any 0x stuff to this?
There was a problem hiding this comment.
no, isValidAddress enforces the 0x requirement
peachbits
force-pushed
the
matthew/get-asset-details
branch
from
7ab0762 to
a5be9a8
Compare
swansontec
approved these changes
May 26, 2025
peachbits
force-pushed
the
matthew/get-asset-details
branch
from
a5be9a8 to
622e181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-core-js#658
Description
none