Skip to content

Add getTokenDetails to EVM and Zano #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented May 19, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

EdgeApp/edge-core-js#658

Description

none

const { contractAddress } = filter
if (contractAddress == null) return []

const valid = EthereumUtil.isValidAddress(contractAddress)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do we need to do any 0x stuff to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, isValidAddress enforces the 0x requirement

@peachbits peachbits force-pushed the matthew/get-asset-details branch from 7ab0762 to a5be9a8 Compare May 26, 2025 20:58
@peachbits peachbits marked this pull request as ready for review May 26, 2025 21:03
@peachbits peachbits force-pushed the matthew/get-asset-details branch from a5be9a8 to 622e181 Compare May 26, 2025 22:08
@peachbits peachbits enabled auto-merge May 26, 2025 22:08
@peachbits peachbits merged commit fb7b0e4 into master May 26, 2025
2 checks passed
@peachbits peachbits deleted the matthew/get-asset-details branch May 26, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants