Sam/duress check pin #661
Merged
Sam/duress check pin #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
May 21, 2025
src/core/login/pin2.ts
Outdated
Comment on lines
182
to
183
| const appId = | ||
| forDuressAccount === true ? login.appId + '.duress' : login.appId |
There was a problem hiding this comment.
If we are already in duress mode, the appId would be .duress.duress.
There was a problem hiding this comment.
Ah, actually login is always loginTree (a root). If it's not a root, then if (username == null) return false would prevent this line from being reached. Unless I misunderstand that non-roots can have a username field? If so, then it's potentially non-root, and .duress.duress is possible, but then the stash search would fail, and we'd get an exception out of this function. So generally this is safe.
You did make me think of another test case. I added it and included changes.
samholmes
force-pushed
the
sam/duress-checkPin
branch
3 times, most recently
from
0d84e48 to
4c8d796
Compare
swansontec
approved these changes
May 22, 2025
samholmes
force-pushed
the
sam/duress-checkPin
branch
from
4c8d796 to
9f60054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
#660
Description
none