Sam/rest o duress #659
Merged
Sam/rest o duress #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
May 21, 2025
This bug is where login with password from the login server does not persist duress mode for the account, but persists it for other accounts when attempting to login using a key. The expected behavior is that login with password or key while in duress mode should always bring you to the duress mode account/stash regardless of whether login was online or offline. This is because online and offline should always behave the same.
samholmes
force-pushed
the
sam/rest-o-duress
branch
2 times, most recently
from
413dcab to
e89b64b
Compare
swansontec
approved these changes
May 22, 2025
src/core/login/login-stash.ts
Outdated
| @@ -61,6 +61,7 @@ export interface LoginStash { | |||
| // PIN v2 login: | |||
| pin2Key?: Uint8Array | |||
| pin2TextBox?: EdgeBox | |||
| pinEnabledLie?: boolean | |||
There was a problem hiding this comment.
Not needed anymore, right?
| * Returns a copy of the PIN login key if one exists on the local device and | ||
| * the app id matches the duress appId. | ||
| */ | ||
| export function findPin2StashDuress( |
There was a problem hiding this comment.
Perfect! This function makes sense.
Completely fake enable and disable pin settings stash by looking at the duress stash within `localUser` reducer and respecting PinDisabledError that is thrown in `loginWithPIN`.
samholmes
force-pushed
the
sam/rest-o-duress
branch
from
e89b64b to
97e6195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none