Extend onSubscribeAddresses to include checkpoints #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
changed the title
swansontec
requested changes
May 19, 2025
| typeof param === 'string' | ||
| ? { | ||
| address: param, | ||
| checkpoint: 'latest' |
There was a problem hiding this comment.
I would use undefined instead of 'latest'. That is the existing pattern in the change server - the checkpoint is optional, and skipping it means we either don't know or care, so check everything.
In either case, "latest" is the opposite of what we want. Even if we did a string, it should be "oldest", to indicate that we don't know the start point, so go back to the beginning.
But yeah, trying to do try { parseInt } is a little annoying, so let's keep the string contents 100% under plugin control. We don't want to insert our own strings here.
swansontec
approved these changes
May 20, 2025
samholmes
force-pushed
the
sam/ecs-updates
branch
from
a8eeca0 to
6f31268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none