William/key management #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
commented
May 1, 2019
src/types/types.js
Outdated
| keyText: string, | ||
| opts?: EdgeCreatePrivateKeyOptions | ||
| ) => Promise<Object>, | ||
| +isPrivateKey?: (walletInfo: EdgeWalletInfo) => Promise<boolean>, |
There was a problem hiding this comment.
Just put canSpend on EdgeCurrencyEngine.
src/types/types.js
Outdated
| +otherMethods: Object, | ||
| +userSettings: Object | void, | ||
|
|
||
| canImportKey(): Promise<boolean>, |
There was a problem hiding this comment.
Move to EdgeCurrencyInfo.
swansontec
force-pushed
the
william/key-management
branch
from
047fe04 to
426d822
Compare
swansontec
force-pushed
the
william/key-management
branch
from
426d822 to
6fe7c42
Compare
swansontec
force-pushed
the
william/key-management
branch
from
6fe7c42 to
d56898d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request needs some additional testing / cleanup before it is ready to be merged. The idea is to get the conversation started.