Skip to content

Sam/evm rpc scan address #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
Merged

Sam/evm rpc scan address #5

merged 4 commits into from
May 22, 2025

Conversation

samholmes
Copy link
Contributor

@samholmes samholmes commented May 17, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits go back & forth a lot. It would be cleaner to just squash them all together, if you don't want to spend the time cleaning them up.

Also, we need some simple cleaners on the scan results.

samholmes added 4 commits May 21, 2025 20:00
This uses etherscan-like API services to query for changes for
addresses.

Implement an adapter pattern for the scanAddress implementation.
@samholmes samholmes force-pushed the sam/EvmRpc-scanAddress branch from af5e071 to f7673b4 Compare May 22, 2025 03:08
@samholmes samholmes merged commit a0c3ea3 into main May 22, 2025
1 check passed
@samholmes samholmes deleted the sam/EvmRpc-scanAddress branch May 22, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants