Added dark theme implementation #154
Conversation
|
Deploy preview for eclipsefdn-solstice-assets ready! Built with commit 56515fe https://deploy-preview-154--eclipsefdn-solstice-assets.netlify.app |
| @@ -0,0 +1,13 @@ | |||
| .prefers-color-scheme{ | |||
There was a problem hiding this comment.
@Linus-CS why is this wrapped in a class?
If you remove that class, we should be able to see your changes live in the preview: https://deploy-preview-154--eclipsefdn-solstice-assets.netlify.app
There was a problem hiding this comment.
@chrisguindon Oops I accidentally left that there. At the beginning I thought it maybe would be a good idea to wrap it in a class, so that instead of modifying the content directly, you would just use the class when creating a site to specify where changes should be applied after turning on dark theme.
I will remove that and push the changes.
| @@ -0,0 +1,13 @@ | |||
| .prefers-color-scheme{ | |||
| @media (prefers-color-scheme: dark) { | |||
| body footer{ | |||
| color: @text-dark-theme; | ||
| } | ||
|
|
||
| body a{ |
There was a problem hiding this comment.
I don't think we want to do that, this will set all our links to @brand-primary; which would include the menu.
Maybe we only change the link color in <main>?
There was a problem hiding this comment.
@chrisguindon I will implement that in my commit too.
Signed-off-by: LinusCS <[email protected]>
Linus-CS
force-pushed
the
os-level-styling
branch
from
e377587 to
56515fe
Compare
2 participants
I have tested the css on the website directly. There probably need to be some adjustments.