Refactor and Enhance Ethereum API Routes#156
Open
CreeptoGengar wants to merge 2 commits into
Open
Conversation
These changes will improve: - Code reliability: Added response status checks for the API. - Readability: Enhanced the comment for the caching constant. - Error handling: Introduced checks for errors in the API response. - Accuracy of status codes: Implemented the use of 502 Bad Gateway for external API errors.
These changes improve the code as follows: - Added a check for response.ok. - Introduced the Transaction interface instead of using any. - Moved the starting block number into a constant. - Enhanced error handling with specific error messages. - The code is now more type-safe.
|
@CreeptoGengar is attempting to deploy a commit to the Eclipse Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces key improvements and refactorings to the
ethereum-dataandget-transactionsAPI routes, including:1. Code Refinement
2. Enhanced Error Handling
3. Optimization
START_BLOCKand cache durations) for better maintainability.fetchcalls to ensure cache settings are explicitly defined.4. Bug Fixes
ethereum-dataandget-transactionsroutes.etherscanAPI calls.5. Environment Variables
NEXT_PUBLICenvironment variables to enhance flexibility for deployments.Files Updated
app/api/ethereum-data/route.ts:app/api/get-transactions/route.ts:Impact
This update improves reliability, maintainability, and performance for fetching Ethereum-related data via the APIs.
Feel free to review and provide feedback. Maintainers are welcome to make edits to this branch.