Query refactor #150
Draft
Query refactor #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o backend_to_engine
…onnections in one place and removing this responsibility from the QueryHandler
…iness logic in data classes
…onnections in one place and removing this responsibility from the QueryHandler
…iness logic in data classes
Co-authored-by: Andreas K. Brandhøj <[email protected]>
* Backend to engine (Ecdar#136) * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * Contributing section added and code snippets updated to be executable on Linux * Rename branched out from readme_update * File used on other branch * WIP: ECDAR reference added, dependency section updated, and spelling fixed * WIP: Backend replaced with Engine to be consistent with naming * Contributing section added and code snippets updated to be executable on Linux * File used on other branch * WIP: Backend replaced with Engine to be consistent with naming * WIP: Engine Configuration enriched * File used on other branch * Line about the deprecated mutation package added * Update src/main/java/ecdar/abstractions/Query.java Co-authored-by: Andreas K. Brandhøj <[email protected]> * WIP: Review changes (part 1/2) * Update src/main/java/ecdar/backend/BackendHelper.java Co-authored-by: Andreas K. Brandhøj <[email protected]> * WIP: Review changes (part 2/2) * startedEngineConnections filtering added to only account for ports of the related engine and comment updated * Found some more strings and vars to update * Review suggestions implemented --------- Co-authored-by: Andreas K. Brandhøj <[email protected]> * WIP: Backend replaced with Engine to be consistent with naming * File used on other branch * WIP: Backend replaced with Engine to be consistent with naming * File used on other branch * BackendDriver refactored to be more readable (method division) * More refactoring --------- Co-authored-by: Andreas K. Brandhøj <[email protected]>
…en main should be merged into this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the code structure related to the
Queryabstraction.Depends on #147