Skip to content

Conversation

@janishorsts
Copy link

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @janishorsts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the continuous integration and delivery pipeline for the EarthBuild Homebrew formula. It introduces a dedicated Earthfile to streamline build and quality assurance processes, alongside updating the earth formula to a new release candidate version. The update also expands support for Linux architectures and improves user experience by guiding them on necessary container runtime installations.

Highlights

  • New CI/CD Earthfile: A new Earthfile has been added to the repository, defining CI/CD targets for building, linting, auditing, and styling the Homebrew formula. This centralizes and automates the quality checks for the formula.
  • Homebrew Formula Update: The Formula/earth.rb file has been updated to reflect a new release candidate version (v0.8.17-rc-0), include bottle checksums for additional Linux architectures (arm64_linux, x86_64_linux), and update the default Buildkitd image used by EarthBuild.
  • User Guidance for Container Runtimes: A new caveats section has been added to the Homebrew formula, providing clear instructions to users on how to install Docker or Podman, which are required for EarthBuild to function.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the earth Homebrew formula for a new release and adds an Earthfile for CI. The formula update is mostly good, with style improvements and new Linux bottles. The new caveats section is a great addition. However, I've found a critical issue in the Earthfile where brew audit is called with invalid flags, which will cause the CI to fail. I've also suggested a couple of improvements in the formula file: one to make the bottle block more concise, and another to align the test command with the user-facing earthly command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants