Skip to content

[echo-server] make ingress fully compatible with various kubernetes versions #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[echo-server] make ingress fully compatible with various kubernetes versions #44

wants to merge 1 commit into from

Conversation

@treksler
Copy link

@treksler treksler commented Apr 13, 2023

  • wrap pathType in a Kubernetes version check
  • automatically handle annotations for kubernetes ingress class in older kubernetes versions
  • eliminate duplicated code in backed definition

@treksler treksler force-pushed the master branch 2 times, most recently from ffa416a to 1f682bf Compare April 13, 2023 20:17
@Ealenn
Copy link
Owner

Ealenn commented Apr 28, 2023

Hello @treksler Thanks for the MRs, could you please change the version on all MRs and list the order to merge ? Everything seem good to me, but I can't merge :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@treksler @Ealenn