Update main branch #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 바깥 컨테이너 범위를 넘어가지 않도록 스타일 수정 - 두 버튼을 감싸는 컨테이너 명: RowContainer
- 배경 콘텐츠가 노출되지 않도록 수정 - BottomFixedContainer에서 margin 대신 padding을 사용하여 버튼 옆의 빈 공간 문제를 해결
- 기존 bottom: calc() 을 paddingBottom: calc() 으로 변경하여 버튼 하단의 콘텐츠 노출을 방지 - paddingTop 을 네비바와 BottomFixedContainer의 간격만큼 추가해서 UX 개선 - BottomFixedContainer의 확장으로 보여지지 않던 '조회수' 부분이 보여지도록 MoreInfoContainer 의 padding-bottom 값 변경
85 0821 피드백 (2)
|
Visit the preview URL for this PR (updated for commit 76b811e): https://k-eum2023--pr91-dev-dlce1jbk.web.app (expires Fri, 30 Aug 2024 00:59:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 773304693819233789eec4fdb709bac90986fc59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr #90 의 내용을 main 에 반영