move python helpers #71
Conversation
casperdcl
commented
Nov 13, 2024
casperdcl
commented
- fixes organisation of files (and usability of PyPI and conda-forge distributions) #70
casperdcl
added
documentation
|
ah ok. I guess I was thinking about having Presumably this will need 0.3.0 as opposed to 0.2.2. I'd be nice to move the C++ stuff as well before we tag though, but I haven't given that any thought really. |
- fixes #70
casperdcl
force-pushed
the
pkg-helpers
branch
from
e770dcd to
693afaa
Compare
| @@ -2,12 +2,11 @@ | |||
| # Copyright (C) 2023-2024 University College London | |||
| # | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| import sys | |||
|
|
|||
| import petsird | |||
There was a problem hiding this comment.
btw I'm leaving this as an absolute import to make it easier for users to copy-paste
There was a problem hiding this comment.
but wouldn't that apply to the line below as well?
There was a problem hiding this comment.
ish... depends on whether you expect users to do from petsird.helpers import ... (which sounds to me like a failure on yardl's part... isn't the point of yardl to not require boilerplate helpers?)
There was a problem hiding this comment.
isn't the point of
yardlto not require boilerplate helpers?
yes, but some of these helpers are a bit too complicated to be able to be auto-generated. (How would you encode matrix multiplications of rigid transformations and coordinates in yardl? Seems very hard...)
There was a problem hiding this comment.
Feel free to change as you see fit :)
I don't know enough about this project's long-term direction to advise either way. |
