Skip to content

fix Invalid JSON desearilaztion beyond buffer end #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 2, 2025
Merged

fix Invalid JSON desearilaztion beyond buffer end #184

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
56470cb
fix https://github.com/ESP32Async/ESPAsyncWebServer/issues/183
ayavilevich May 23, 2025
2070e49
make edge case handing in AsyncCallbackJsonWebHandler more robust
ayavilevich May 24, 2025
172a88d
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] May 24, 2025
1db83fd
refactor fix to be more robust and encapsulated
ayavilevich May 28, 2025
f585543
Merge branch 'main' of https://github.com/ayavilevich/ESPAsyncWebServer
ayavilevich May 28, 2025
a9fc5c1
Merge branch 'main' into main
mathieucarbou May 29, 2025
50d5112
ci(pre-commit): Apply automatic fixes
pre-commit-ci-lite[bot] May 29, 2025
175880d
Merge branch 'main' into main
mathieucarbou Jun 1, 2025
426aea1
Cleanup proposal fix for
mathieucarbou Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AsyncJson.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,12 @@ void AsyncCallbackJsonWebHandler::handleRequest(AsyncWebServerRequest *request)
if (json.success()) {
#elif ARDUINOJSON_VERSION_MAJOR == 6
DynamicJsonDocument jsonBuffer(this->maxJsonBufferSize);
DeserializationError error = deserializeJson(jsonBuffer, (uint8_t *)(request->_tempObject));
DeserializationError error = deserializeJson(jsonBuffer, (uint8_t *)(request->_tempObject), request->contentLength());
if (!error) {
JsonVariant json = jsonBuffer.as<JsonVariant>();
#else
JsonDocument jsonBuffer;
DeserializationError error = deserializeJson(jsonBuffer, (uint8_t *)(request->_tempObject));
DeserializationError error = deserializeJson(jsonBuffer, (uint8_t *)(request->_tempObject), request->contentLength());
if (!error) {
JsonVariant json = jsonBuffer.as<JsonVariant>();
#endif
Expand Down