Fix --mail-type args to use comma-separated values instead of repeated flags#4969
Merged
Fix --mail-type args to use comma-separated values instead of repeated flags#4969
Conversation
…flags Agent-Logs-Url: https://github.com/ESMCI/cime/sessions/3844aabe-19bc-468e-a9c0-5dbf29bcde11 Co-authored-by: jgfouca <7292036+jgfouca@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix mail-type args not being set correctly on Perlmutter
Fix --mail-type args to use comma-separated values instead of repeated flags
Apr 22, 2026
whannah1
approved these changes
Apr 22, 2026
rljacob
approved these changes
Apr 22, 2026
Member
|
I don't feel a need to review this given others' reviews, so removing myself as reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On SLURM systems (e.g. Perlmutter), multiple mail types were being submitted as repeated flags (
--mail-type end --mail-type fail) instead of a single comma-separated argument (--mail-type end,fail). This caused SLURM to silently drop the notification on job completion.Root cause: The
elsebranch in_submit_single_jobwas joiningmail_type_argsusing the flag itself as separator, duplicating it:The
-m(PBS) path, which concatenates without any separator, is unchanged.Fixes #4968
Checklist