Repository navigation
Conversation
New section in CONTRIBUTING.md and some GitHub templates; new AGENTS.md file.
c837e7b to
25118f5
Compare
|
Added "next" because I figure we should agree as a group on these instructions. |
(Except for keeping the AI Disclosure field up-to-date.)
Across all templates and CONTRIBUTING.md. Also added "Brief summary" and "Further details" sections to science discussion and other templates, which had no sections.
ekluzek
left a comment
There was a problem hiding this comment.
I like this and glad we'll talk about it. I have a few questions we can go over tomorrow. I'm not approving now, since it's a draft.
|
|
||
| **Do not submit unreviewed AI output to this repository.** Issue and PR descriptions, comments, and review responses must reflect your own reasoning and understanding. Translation, grammar, and phrasing assistance are welcome, provided you verify the meaning. | ||
|
|
||
| **Do not delegate conversations with maintainers to an agent.** The maintainers of this repo are human beings who will use their human brains to review every single line of your contribution. Please show them the same courtesy when discussing an issue or PR. |
There was a problem hiding this comment.
We do want to aspire to reviewing every line of code carefully. But, realistically as humans we won't be able to do that for large changes, or lines we can't advise on. So I think maybe we soften the wording a bit? But, also giving the expectation that every line is reviewed by a human might also help people to NOT submit huge changes. So maybe we leave it in.
There was a problem hiding this comment.
I also wonder about giving a ballpark limitation on the size of a PR. For example, saying something like
Contributions that exceed reasonable size for humans to review may be rejected (many tens of thousand lines of changes).
There was a problem hiding this comment.
I would say that, if people aren't sure about the acceptable size of a PR, they should discuss that with us on the issue page they're supposed to have opened. We could also add something here like, "We may ask you to break up large PRs into smaller pieces," without giving any sort of number. ("Many tens of thousands of lines of changes" is way, way too high of a number anyway in my opinion.)
There was a problem hiding this comment.
Also:
We do want to aspire to reviewing every line of code carefully. But, realistically as humans we won't be able to do that for large changes, or lines we can't advise on
That's an argument for (1) not letting people bring in large changes and (2) bringing in subject-matter experts to review the things that we as SEs can't—not for letting people bring in code we don't understand.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
And fix a typo. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Gemini 3.8 Flash <noreply@google.com>
Co-Authored-By: Gemini 3.8 Flash <200291788+gemini-code-assist@users.noreply.github.com>
f1950b1 to
2b0bce7
Compare
Co-Authored-By: ChatGPT 5.6 Terra <267193182+codex@users.noreply.github.com>
Description of changes
New section in CONTRIBUTING.md and some GitHub templates; new AGENTS.md file. I'm intentionally not including any "skills" or whatnot; this PR is solely intended to help stem the tide of AI-written contributions.
Borrowed heavily from CIME.
Main points of emphasis:
Remaining work:
After merge to master:
Specific notes
Contributors other than yourself, if any: None
CTSM issues resolved or otherwise addressed, if any:
Any user interface changes (namelist or namelist defaults changes)? No
Testing planned or performed, if any:
AI disclosure
/claude-api prompt-audit)Requirements before merge: