-
Notifications
You must be signed in to change notification settings - Fork 328
CTSM5.3.04X: MEGAN coefs fix, answer changes for MEGAN #3065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like lots of trailing white space cleanup with a few answer changing modifications. Thanks for opening up this PR.
One more question, in #3016 there was a suggestion to set A few questions / options to consider:
@tilmes, @HuiWangWanderInGitHub, @lkemmons, @rosiealice can you weigh in here? |
I think it would be great to have the soil moisture (drought) impact on MEGAN emissions be a namelist option (on/off). |
@lkemmons Do you have source mods where these changes at least hacked in? |
No, sorry, I have not implemented a namelist option.
…On Tue, Apr 15, 2025 at 4:16 PM Francis Vitt ***@***.***> wrote:
I think it would be great to have the soil moisture (drought) impact on
MEGAN emissions be a namelist option (on/off). Maybe also with the option
to provide an overall scaling factor to the new gamma_sm calculation, which
I think Rosie suggested.
@lkemmons <https://github.com/lkemmons> Do you have source mods where
these changes at least hacked in?
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7O35PL5WSQHCXEHVID2ZWANJAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY2TENZWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*fvitt* left a comment (ESCOMP/CTSM#3065)
<#3065 (comment)>
I think it would be great to have the soil moisture (drought) impact on
MEGAN emissions be a namelist option (on/off). Maybe also with the option
to provide an overall scaling factor to the new gamma_sm calculation, which
I think Rosie suggested.
@lkemmons <https://github.com/lkemmons> Do you have source mods where
these changes at least hacked in?
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7O35PL5WSQHCXEHVID2ZWANJAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY2TENZWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I was referring to changes to the code for "the soil moisture (drought) impact on MEGAN emissions" and "overall scaling factor to the new gamma_sm calculation" |
The new code for gamma_sm is already in. We want to include the option to
have that be =1, or use the new calculation.
An overall scale factor would also have to be added.
…On Tue, Apr 15, 2025 at 4:36 PM Francis Vitt ***@***.***> wrote:
No, sorry, I have not implemented a namelist option.
I was referring to changes to the code for "the soil moisture (drought)
impact on MEGAN emissions" and "overall scaling factor to the new gamma_sm
calculation"
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7LRAZV5NEQU24RKKWD2ZWCWXAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY4DIMZYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*fvitt* left a comment (ESCOMP/CTSM#3065)
<#3065 (comment)>
No, sorry, I have not implemented a namelist option.
I was referring to changes to the code for "the soil moisture (drought)
impact on MEGAN emissions" and "overall scaling factor to the new gamma_sm
calculation"
—
Reply to this email directly, view it on GitHub
<#3065 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH5BH7LRAZV5NEQU24RKKWD2ZWCWXAVCNFSM6AAAAAB24YUFXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGY4DIMZYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
As @HuiWangWanderInGitHub noted in #3016 around line 568 in clm/src/biogeochem/VOCEmissionMod.F90
where use_megan_gamma_sm is a namelist parameter. I'm less confident in how to apply the idea of
If we add a modifier into gamma_sm I suggest it go on the CLM parameter file.my hacky python code for this example is below:
Hope this helps. |
I guess if we like the used of
|
@wwieder Thanks for putting this together! I think the idea of using a lower threshold makes more sense to me since it simply postpones the impact of drought on isoprene by increasing the drought severity threshold. Besides that, I think adding a namelist option to turn off the drought impact could be helpful if drought conditions are not of interest in users' simulations. "min_megan_gamma_sm" is also an interesting idea, but it doesn't seem scientifically reasonable because isoprene emissions would shut down under severe drought conditions. |
In sandbox:
I have implemented these namelist options:
Do we want to keep the These options can be set in |
I think my preference would be to just use I think that was your question, Francis? |
@fvitt we'd like to do this in small steps. So we'll bring this in as is. But, then there will be a follow on PR that includes the namelist changes verified as a bit-for-bit, and a final change that changes the namelist defaults. So we end up with 2 tags. This isolates the b4b part and ensures that it doesn't change answers. And isolates the answer changing parts to small changes that can be easily examined.
Does this all make sense? We should probably chat about this a bit. By, doing "1" now we get the most important part ASAP. |
OK, it's passing testing as expected in aux_clm on both Derecho and Izumi, with answers identical. So I'll now try some testing with updated megan namelists where we'll expect answers to change. |
Merge b4b-dev to master
…at the validation will function correctly
Conflicts: .gitmodules
OK, the puzzles are all solved now. From two tests one Derecho and one on Izumi I now see differences in VOC's for one of the VOC fields in the cpl log file:
|
In the CTSM SE meeting we decided we would update cmeps and cime and revert the st_archive change. And this will go into b4b-dev as well. |
…n cesm3_0_alpha06g (which will become cesm3_0_beta06)
…nd drydep_list, maybe this should be used for all namelist items sent to the validate method?
OK, with the updated cime, I'm having some tests hanging on Derecho, and mpi-serial tests fail to build on Izumi. I think this probably means to get things to work, we'd need to update ccs_config as well. But, there is an answer changing tag in ccs_config, so I don't want to bring that in right now. I think the solution is to go back to the earlier version of cime that I saw working, and bring that on master. And they'll be separate work on b4b-dev and master to bring in other submodule updates. Here are the tests hanging and failing to build...
|
OK, dependency issue came in. The CMEPS tag that includes the MEGAN change, also brought in st_archiver changes that don't work without the updated cime tag. So I'm going to do some testing outside this branch to find out what submodules work together and don't. And will bring in some other PR's to either b4b-dev, or master (that I likely will merge in with this one) so I can figure out steps of what all works together. |
Hey @ekluzek, I'm wondering where we are on the timing of merging this PR? |
In the post above I talk about dependency issues and abstractly talk about some steps in other PR's. At this point the steps are well defined and progress has been made. These are the things I'm viewing as requirements to bring this in:
So these are the steps I'm working on:
|
Description of changes
Corrections on how MEGAN coefficients are applied.
Depends on ESCOMP/CMEPS#557
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #3016
Fixes #2710
Are answers expected to change (and if so in what way)? Yes, for MEGAN fields
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: scientific testing is underway