Skip to content

feat: only allow user with email whiteslited to access benchmark pages #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rahmandawibowo-vito wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: only allow user with email whiteslited to access benchmark pages #62

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e0961
feat: only allow user with email whiteslited to access benchmark pages
rahmandawibowo-vito Jan 6, 2026
a70201c
Merge branch 'main' into filter-content-acl
rahmandawibowo-vito Jan 9, 2026
e68878f
fix: read benchmark scenarios instead of algorithm records for acl ma…
rahmandawibowo-vito Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ declare namespace App {
username?: string;
email?: string | null;
roles?: string[];
emailDomain?: string | null;
};
}
}
6 changes: 4 additions & 2 deletions src/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { config as authConfig } from "../auth.config";
import { isFeatureEnabled } from "./lib/featureflag";
import aclMapping from "./acl-mapping.json";

const protectedPaths = ["/api/admin/services/benchmarks.json", "/dashboard"];
const protectedPaths = ["/api/admin/services/", "/dashboard"];

/**
* Check if the request is for an API endpoint
Expand Down Expand Up @@ -52,14 +52,16 @@ export const onRequest = defineMiddleware(async (context, next) => {
const session = await getSession(context.request, authConfig);

if (session?.user) {
const emailDomain = `@${session.user.email?.split("@").pop()}`;

context.locals.user = {
name: session.user.name,
username: session.user.username,
email: session.user.email,
roles: session.user.roles || [],
emailDomain,
};

const emailDomain = `@${context.locals.user.email?.split("@").pop()}`;
if (context.locals.user.roles?.includes("administrator") || aclMapping.acl.admin.includes(emailDomain)) {
return next();
}
Expand Down
11 changes: 10 additions & 1 deletion src/pages/api/admin/services/[id]/benchmarks.json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
PARQUET_MONTH_COVERAGE,
getUrlsFromRequest,
} from "@/lib/parquet-datasource";
import aclMapping from "@/acl-mapping.json";

/**
* @openapi
Expand Down Expand Up @@ -92,7 +93,7 @@ import {
* - Benchmark
* - Scenario
*/
export const GET: APIRoute = async ({ params, request }) => {
export const GET: APIRoute = async ({ params, request, locals }) => {
const scenario = params.id;

if (!scenario) {
Expand All @@ -102,6 +103,14 @@ export const GET: APIRoute = async ({ params, request }) => {
);
}

// @ts-expect-error
if (!aclMapping.records[scenario]?.includes(locals.user?.emailDomain)) {
return new Response(
JSON.stringify({ message: "Scenario not found." }),
{ status: 404, headers: { "Content-Type": "application/json" } },
);
}

try {
const urlResponse = await getUrlsFromRequest(request);
if (urlResponse instanceof Response) {
Expand Down
9 changes: 7 additions & 2 deletions src/pages/api/admin/services/benchmarks.json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
PARQUET_MONTH_COVERAGE,
getUrlsFromRequest,
} from "@/lib/parquet-datasource";
import aclMapping from "@/acl-mapping.json";

/**
* @openapi
Expand Down Expand Up @@ -71,7 +72,7 @@ import {
* - Admin
* - Benchmark
*/
export const GET: APIRoute = async ({ request }) => {
export const GET: APIRoute = async ({ request, locals }) => {
try {
const urlResponse = await getUrlsFromRequest(request);
if (urlResponse instanceof Response) {
Expand Down Expand Up @@ -102,7 +103,11 @@ export const GET: APIRoute = async ({ request }) => {
ORDER BY "scenario_id";
`;

const data = (await executeQuery(query)) as BenchmarkSummary[];
let data = (await executeQuery(query)) as BenchmarkSummary[];
data = data.filter((benchmark) => {
// @ts-expect-error
return aclMapping.records[benchmark.scenario_id]?.includes(locals.user?.emailDomain)
Copy link
Collaborator Author

@rahmandawibowo-vito rahmandawibowo-vito Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find a way to make this rule reusable

});

return Response.json(data);
} catch (error) {
Expand Down
Loading