Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cron): update work chronicles cron #95

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

antoineneff
Copy link
Member

@antoineneff antoineneff commented Mar 18, 2024

Contexte

Cette PR fixe le cron Work Chronicles qui ne fonctionne plus depuis quelques temps déjà. Le site web utilise maintenant la plateforme Substack pour gérer les articles.

Changements

  • utilise l'api substack du site pour trouver les nouveaux postes
  • adapte l'interface
  • formatte le titre utile de l'article
  • renomme WorkChornicles.spec.ts -> WorkChronicles.spec.ts

Exemple

Screenshot 2024-03-18 at 22 37 23

@antoineneff
Copy link
Member Author

Les tests passent en local, je ne sais pas s'il y a une limitation de l'api substack au niveau du host ou qqch dans ce genre 🤔

@targos
Copy link
Member

targos commented Mar 19, 2024

ça passe aussi sur mon PC

@Xstoudi
Copy link
Member

Xstoudi commented Mar 19, 2024

C'est peut-être pas utile de faire un test qui s'occupe de la partie fetch, autant qu'il travaille sur un fixture du coup :/

@Xstoudi
Copy link
Member

Xstoudi commented Mar 19, 2024

Ah nan en fait mal vu, LGTM on peut merge comme ça imo.

@Xstoudi Xstoudi self-requested a review March 19, 2024 11:05
@Purexo Purexo merged commit b5b082c into ES-Community:main Mar 29, 2024
1 of 2 checks passed
@antoineneff antoineneff deleted the fix/work-chronicles branch March 29, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants