[hls-fuzzer][NFC] Optimize transfer function calling convention#968
Merged
Conversation
Prior to this PR the conjunction type system had one performance difference compared to one implementing a single large type system: When dispatching to the transfer functions of the sub-type systems, the code had to copy the sub-context for that type system into a new `std::tuple` of `OpaqueContext`s of all instances of that sub-context. The new PR addresses this issue by making the universal calling convention just take a tuple of `const void*`, meaning we do not need to construct a tuple of `OpaqueContext`s that directly contain the sub-context within them. To enable this feature, `OpaqueContext` had to be refactored slightly to not use `std::any` anymore and allow access to its internal storage. Another benefit is that `OpaqueContext` could now be made a move-only type that is never copied anywhere.
Jiahui17
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR the conjunction type system had one performance difference compared to one implementing a single large type system: When dispatching to the transfer functions of the sub-type systems, the code had to copy the sub-context for that type system into a new
std::tupleofOpaqueContexts of all instances of that sub-context.The new PR addresses this issue by making the universal calling convention just take a tuple of
const void*, meaning we do not need to construct a tuple ofOpaqueContexts that directly contain the sub-context within them. To enable this feature,OpaqueContexthad to be refactored slightly to not usestd::anyanymore and allow access to its internal storage. Another benefit is thatOpaqueContextcould now be made a move-only type that is never copied anywhere.