fix(wallet): make Stellar payment submission idempotent across ambigu… - #427
Open
Ukorstack wants to merge 1 commit into
Open
fix(wallet): make Stellar payment submission idempotent across ambigu…#427Ukorstack wants to merge 1 commit into
Ukorstack wants to merge 1 commit into
Conversation
…ous outcomes (EF-CHAIN#197) Build and sign the transaction envelope once before the retry loop, and reuse the exact same signed envelope across ambiguous retries (timeout / connection loss). After any ambiguous outcome, query Horizon by the pre-computed transaction hash: if the transaction landed, return success immediately instead of resubmitting, preventing duplicate payments. The envelope is only rebuilt with a fresh sequence number on a genuine tx_bad_seq conflict. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ous outcomes (#197)
Build and sign the transaction envelope once before the retry loop, and reuse the exact same signed envelope across ambiguous retries (timeout / connection loss). After any ambiguous outcome, query Horizon by the pre-computed transaction hash: if the transaction landed, return success immediately instead of resubmitting, preventing duplicate payments. The envelope is only rebuilt with a fresh sequence number on a genuine tx_bad_seq conflict.
What changed
Why
Related issue
Closes #N
Tests added
How to test
Checklist
npm testpasses and new backend logic has tests inapps/api/test/npm run lint/npm run build --workspace=apps/<app>).envfiles committed./scripts/secret-scan-self-test.shlocally).env.exampleand the READMESECURITY.md)Screenshots / notes (for UI changes)
closes #228